Skip to content

Allow recording of videos at any duration #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TLAlice wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow recording of videos at any duration #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions runtimes/web/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,11 @@ async function loadCartWasm () {

let videoRecorder = null;
function recordVideo () {
if (videoRecorder != null) {
return; // Still recording, ignore
if (videoRecorder != null) { // Stops recording after hitting the record key during recording
videoRecorder.requestData();
videoRecorder.stop();
videoRecorder = null;
return;
}

const mimeType = "video/webm";
Expand All @@ -148,11 +151,7 @@ async function loadCartWasm () {
};

videoRecorder.start();
setTimeout(() => {
videoRecorder.requestData();
videoRecorder.stop();
videoRecorder = null;
}, 4000);

}

let savedState = null;
Expand Down