make diskw skip localStorage.setItem for non-host players #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recently i got surprised to see diskw during a netplay performs localStorage.setItem even on non-host players. (and it overwrote the save data for the cart i happened to have on the browser.) as the disk buffer is a part of the shared state provided by the netplay host, it's more natural to make diskw perform localStorage.setItem only on the host. cf. aduros#837
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recently i got surprised to see diskw during a netplay performs localStorage.setItem even on non-host players. (and it overwrote the save data for the cart i happened to have on the browser.) as the disk buffer is a part of the shared state provided by the netplay host, it's more natural to make diskw perform localStorage.setItem only on the host.
cf. #837