Skip to content

Conversation

ar-cyber
Copy link

Considering that this is a change in how certain APIs will work, it's technically eligible for it's own section.

As far as my knowledge goes I'm unsure if any wrappers have implemented this.

Copy link

netlify bot commented Aug 27, 2025

Deploy Preview for discord-libs ready!

Name Link
🔨 Latest commit 0fd02a7
🔍 Latest deploy log https://app.netlify.com/projects/discord-libs/deploys/68b0e3406ca80400080bf21f
😎 Deploy Preview https://deploy-preview-332--discord-libs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Icebluewolf
Copy link

I think this would work better as "Modal Components" with an int representing the phase. Then there can be a separate table for a description of each phase

@ar-cyber
Copy link
Author

ar-cyber commented Aug 27, 2025

I think this would work better as "Modal Components" with an int representing the phase. Then there can be a separate table for a description of each phase

The point of libs.advaith.io is to be simple. I think I'll keep it a yes no.

@ar-cyber ar-cyber requested a review from Soheab August 28, 2025 00:15
Copy link
Contributor

@KubaZ2 KubaZ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NetCord supports the new modal components

@ar-cyber
Copy link
Author

This PR was meant for the infrastructure for reporting the state of new modal components, not the ones which have them.

@ar-cyber ar-cyber requested a review from KubaZ2 August 28, 2025 23:13
@Lulalaby
Copy link
Contributor

Lulalaby commented Sep 7, 2025

This shouldn't be merged for a long time cause the modal updates are split in parts.
It's gonna take a good while for all libs to implement the changes / add features.
Right now only a handful even started working on it and there's more to come.
It won't even be just "one pr".

It might be worth considering reworking the whole site at some other time to support more details.

not the ones which have them

Then don't touch them. Pycord i.e. doesn't even has it released yet. It only on dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants