-
Notifications
You must be signed in to change notification settings - Fork 122
Add New Modal Components field #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for discord-libs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I think this would work better as "Modal Components" with an int representing the phase. Then there can be a separate table for a description of each phase |
The point of libs.advaith.io is to be simple. I think I'll keep it a yes no. |
Co-authored-by: Soheab <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NetCord supports the new modal components
Co-authored-by: Kuba_Z2 <[email protected]>
This PR was meant for the infrastructure for reporting the state of new modal components, not the ones which have them. |
This shouldn't be merged for a long time cause the modal updates are split in parts. It might be worth considering reworking the whole site at some other time to support more details.
Then don't touch them. Pycord i.e. doesn't even has it released yet. It only on dev |
Considering that this is a change in how certain APIs will work, it's technically eligible for it's own section.
As far as my knowledge goes I'm unsure if any wrappers have implemented this.