Publish src/ for bundler consumers extending ChatWindow - #574
Open
agritheory wants to merge 1 commit into
Open
Conversation
Include src in package files and add a ./src/* export map so bundlers can import SFCs and styles without cloning the repository. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/in the published npm package (filesfield)../src/*subpath export so Vite/Webpack consumers can import SFCs and SCSS when extendingChatWindow.vuevia Vueextends, without vendoring or git-cloning the repo.Motivation
The default npm tarball only ships
dist/andtypes/. Apps that extend upstream components (rather than using the web component entrypoint alone) need access to source SFCs and styles. We hit this integrating vue-advanced-chat into a Frappe desk bundle with a custom message footer.No runtime/component behavior changes in this PR — packaging only.
Test plan
npm packincludessrc/lib/ChatWindow.vueandsrc/styles/index.scssimport { register } from 'vue-advanced-chat'consumers unchangedvue-advanced-chat/src/lib/ChatWindow.vueMade with Cursor