Conversation
…ieval and property searching - Added `_getRootModelTargets` method to normalize root model targets for searching in compact models. - Introduced `_findPropertyByKeys` method to search for properties by multiple keys in target nodes. - Updated TypeScript definitions to include the new methods and improved documentation for existing methods.
- Added tests for the new 'Compact model V1' to validate agent and topic metadata computations. - Updated existing tests to ensure compatibility with compact models by setting the `amf` property on the element. - Introduced operation-level agent detection tests to verify agent handling in operation nodes. - Improved assertions to check for defined web API outputs across various test cases.
leandrogilcarrano
approved these changes
Jan 28, 2026
NazaQuintero
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance AmfHelperMixin with new utility methods for model target retrieval and property searching
_getRootModelTargetsmethod to normalize root model targets for searching in compact models._findPropertyByKeysmethod to search for properties by multiple keys in target nodes.Problem
The agent codegenie icon was not displaying for operations in
api-summarycomponent when loading compact AMF specifications. This occurred becauseAmfHelperMixinmethods (_computeAgents,_computeNodeAgent) were not correctly resolving custom domain properties in compact models where:customDomainPropertiespointing to other nodes (as explained by AMF developers)#10but are stored under keys likeamf://id#10Solution
Enhanced
AmfHelperMixinto properly handle compact models by:1. Recursive Navigation (
_findCustomDomainPropertyByKey)customDomainProperties2. Root Model Resolution (
_resolveCustomDomainProperty)3. Code Refactoring
_getRootModelTargets()helper method to normalize root model access_findPropertyByKeys()helper method to search properties by multiple key formatsChanges
src/AmfHelperMixin.js: Enhanced custom domain property resolution methodssrc/AmfHelperMixin.d.ts: Updated type definitionsTesting
customDomainPropertiesRelated
Fixes issue where agent codegenie icon was not displayed in
api-summarycomponent for compact specs.