Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for indexing UI5 XML views #179

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

lcartey
Copy link
Contributor

@lcartey lcartey commented Mar 25, 2025

This PR adds support to our JavaScript extractor hook to automatically index UI5 XML views.

Per the documentation all such views should end with the suffix .view.xml, so we do not need to consider the contents when determining what to index.

In addition to this PR, I have also opened a PR on github/codeql to ensure the following relevant UI5 and XSJS .json files are indexed:

  • *.view.json
  • xs-app.json
  • manifest.json

We document this in the post-finalize.sh hook to ensure it's clear where this happens.

@jeongsoolee09 can you please confirm that after these changes we would now capture all relevant CAP, UI5 and XSJS files during extraction?

@lcartey lcartey requested a review from jeongsoolee09 March 25, 2025 17:27
@jeongsoolee09
Copy link
Contributor

Yes, with the three file patterns we're capturing all of the data formats used by our queries. There's another special file called XS Application descriptor with name .xsapp (example) that is a JSON in disguise much like .xsaccess. However, it's irrelevant to our queries and can be ignored.

Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongsoolee09 jeongsoolee09 merged commit 3dc4f40 into main Mar 26, 2025
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the lcartey/add-xml-extraction branch March 26, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants