New Compiler: Accept UTF-8 within '…'
#2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scanner accepts '…' containing a byte sequence that specifies a Unicode code point in utf8 format. Result is the code point. Only when scanner is created with the newly created parameter 'use_utf8' set to true. Inline calls to 'cc_parse()' and 'cc_scan()', kill those functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2909
Allow UTF-8 byte sequences within single quotes. This is equivalent to the codepoint of the respective byte sequence.
Typical code:
I'm taking this as an opportunity to refactor the code a bit by inlining and then killing
cc_parse()andcc_scan(). (Both functions had been reserved for internal use in googletests.)