Impact
JSON.parse(env.adapterConfig) is called without error handling in three locations within the gRPC service. While the data originates from the server's own SQLite database and should always be valid JSON, database corruption, migration errors, or unexpected state could cause an unhandled exception that crashes the gRPC handler.
Additionally, the parsed result is cast as Record<string, unknown> and passed to adapter methods without property validation, creating a theoretical prototype pollution surface if the database is compromised.
Affected code:
packages/server/src/grpc-service.ts:415 — reconnectOrProvision handler
packages/server/src/grpc-service.ts:482 — stopEnvironment handler
packages/server/src/grpc-service.ts:498 — destroyEnvironment handler
Patches
Fix: Wrap in try-catch and return a meaningful gRPC error:
let config: Record<string, unknown>;
try {
config = JSON.parse(env.adapterConfig) as Record<string, unknown>;
} catch {
throw new ConnectError("Invalid adapter configuration", Code.Internal);
}
Workarounds
Ensure database integrity. Back up the SQLite database regularly.
Resources
- CWE-754: Improper Check for Unusual or Exceptional Conditions
- File:
packages/server/src/grpc-service.ts
References
Impact
JSON.parse(env.adapterConfig)is called without error handling in three locations within the gRPC service. While the data originates from the server's own SQLite database and should always be valid JSON, database corruption, migration errors, or unexpected state could cause an unhandled exception that crashes the gRPC handler.Additionally, the parsed result is cast as
Record<string, unknown>and passed to adapter methods without property validation, creating a theoretical prototype pollution surface if the database is compromised.Affected code:
packages/server/src/grpc-service.ts:415—reconnectOrProvisionhandlerpackages/server/src/grpc-service.ts:482—stopEnvironmenthandlerpackages/server/src/grpc-service.ts:498—destroyEnvironmenthandlerPatches
Fix: Wrap in try-catch and return a meaningful gRPC error:
Workarounds
Ensure database integrity. Back up the SQLite database regularly.
Resources
packages/server/src/grpc-service.tsReferences