Impact
melange lint --persist-lint-results (opt-in flag, also usable via melange build --persist-lint-results) constructs output file paths by joining --out-dir with the arch and pkgname values read from the .PKGINFO control file of the APK being linted. In affected versions these values were not validated for path separators or .. sequences, so an attacker who can supply an APK to a melange-based lint/build pipeline (e.g. CI that lints third-party APKs, or build-as-a-service) could cause melange to write lint-<pkgname>-<pkgver>-r<epoch>.json to an arbitrary .json path reachable by the melange process. The written file is a JSON lint report whose content is partially attacker-influenced. There is no direct code-execution path, but the write can clobber other JSON artifacts on the filesystem. The issue only affects deployments that explicitly pass --persist-lint-results; the flag is off by default.
Patches
Fixed in melange v0.43.4 by validating arch and pkgname for .., /, and filepath.Separator before path construction in pkg/linter/results.go (commit 84f3b45).
Workarounds
Do not pass --persist-lint-results when linting or building APKs whose .PKGINFO contents are not fully trusted. Running melange as a low-privileged user and confining writes to an isolated directory also limits impact.
Credits
melange thanks Oleh Konko (@1seal from 1seal.org) for discovering and reporting this issue.
References
Impact
melange lint --persist-lint-results(opt-in flag, also usable viamelange build --persist-lint-results) constructs output file paths by joining--out-dirwith thearchandpkgnamevalues read from the.PKGINFOcontrol file of the APK being linted. In affected versions these values were not validated for path separators or..sequences, so an attacker who can supply an APK to a melange-based lint/build pipeline (e.g. CI that lints third-party APKs, or build-as-a-service) could cause melange to writelint-<pkgname>-<pkgver>-r<epoch>.jsonto an arbitrary.jsonpath reachable by the melange process. The written file is a JSON lint report whose content is partially attacker-influenced. There is no direct code-execution path, but the write can clobber other JSON artifacts on the filesystem. The issue only affects deployments that explicitly pass--persist-lint-results; the flag is off by default.Patches
Fixed in melange v0.43.4 by validating
archandpkgnamefor..,/, andfilepath.Separatorbefore path construction inpkg/linter/results.go(commit 84f3b45).Workarounds
Do not pass
--persist-lint-resultswhen linting or building APKs whose.PKGINFOcontents are not fully trusted. Running melange as a low-privileged user and confining writes to an isolated directory also limits impact.Credits
melange thanks Oleh Konko (@1seal from 1seal.org) for discovering and reporting this issue.
References