Fix: include subtitle field in podcast RSS feeds (#4305) - #5536
Open
violawang0401-cloud wants to merge 2 commits into
Open
violawang0401-cloud wants to merge 2 commits into
violawang0401-cloud wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
Fixed subtitle support in RSS feeds.
Which issue is fixed?
Fixes #4305
In-depth Description
<itunes:subtitle>was already handled when generating the RSS XML, but the subtitle was not being stored inFeedEpisode.I added the subtitle field to
FeedEpisodeand passed it from both podcast episodes and books. I also added it to the update fields and added a database migration for the new column.How have you tested this?
Tested locally with a podcast and an audiobook.
For both, I added a subtitle and generated the RSS feed, then checked that
<itunes:subtitle>appeared correctly in the XML.I also tested the database migration locally by simulating a server version upgrade and confirmed that the new subtitle column was added successfully.
Screenshots
N/A (Backend XML change only)