Fix quick match not storing the episode guid - #5544
Open
davidlinke wants to merge 1 commit into
Open
davidlinke wants to merge 1 commit into
davidlinke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
Resolves duplicate episodes appearing after importing podcasts into audiobookshelf
Which issue is fixed?
No existing reported issue
In-depth Description
After importing an existing podcast library into audiobookshelf, I started getting duplicate episodes due to it re-downloading ones I already had. Quick match looks each episode up in the RSS feed and fills in what's missing by copying the download URL, title and dates, but not the guid.
checkMatchesGuidOrEnclosureUrl()matches only on the guid or the enclosure URL, and since imported episodes have neither, every feed check treated them as new and downloaded them again. So a quick-matched episode has no guid, and the duplicate check won't recognize the episode.How have you tested this?
extraData.guidandenclosureURL, reproducing the imported-episode state.POST /api/podcasts/:id/match-episodesendpoint. Before fix, observe extraData.guid is missing. After fix, observe extraData.guid exists and the duplicate check matches it.