Parse labeled series numbers above 999 - #5548
Open
justadityaraj wants to merge 1 commit into
Open
justadityaraj wants to merge 1 commit into
justadityaraj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
Parse labeled series sequence numbers above 999 without changing how unlabeled four-digit prefixes are interpreted.
Which issue is fixed?
Related to #4781 and #5103.
In-depth Description
Problem / Context
The folder parser limits every series sequence to three digits. As a result, documented labels such as
Vol 1456are not recognized, even though a label makes the value unambiguous and was recommended as the workaround for four-digit sequences. The remaining folder text is then parsed into the wrong metadata fields.Changes
Vol,Volume, andBooksequences to contain more than three digits.1456 - Titlecontinues to be treated as a publication year.User impact
Libraries with long-running serials can use an explicit label and have the sequence, publication year, and title scanned into the correct fields. Existing unlabeled year-based folder names keep their current meaning.
How have you tested this?
Verification
upstream/masterbefore the parser change and passes afterward.npx mocha test/server/utils/scandir.test.js— 3 passing.npm test— 356 passing.git diff --check— passed.Screenshots
N/A — server-side folder metadata parsing only.