Conversation
These are in use server code only. 1. server/model/ApiKey.js imports jsonwebtoken 2. server/ imports uuid in many places 3. server/libs vendored code imports all the rest These currently work by coincidence because something else defines them to be available in node_modules/. Minimal package-lock.json ensures that no new version is introduced and server code still uses same versions as before.
slagiewka
force-pushed
the
phantom-deps
branch
from
September 10, 2026 11:57
b252db7 to
9549527
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
These are in use server code only.
These currently work by coincidence because something else defines them to be available in node_modules/.
Minimal package-lock.json ensures that no new version is introduced and server code still uses same versions as before.
Which issue is fixed?
No reported issue (server works without it).
In-depth Description
How have you tested this?
Started server, generated clients, walked through the UI, downloaded and played a podcast.
Screenshots