Fix wrong payment code #128
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Request Description
Issue Description
This merge request addresses an issue in the Adyen payment method filtering for Hyvä Checkout. In the original implementation, the credit card payment method (
adyen_cc) was incorrectly mapped to "card" when checking against available payment methods from Adyen's API. However, Adyen's API expects this payment method to be identified as "scheme" rather than "card".Fix Implementation
The fix changes the return value in the
collectMethodCodeWithoutPrefixmethod from "card" to "scheme" when handling the credit card payment method. This ensures proper mapping between Magento's payment method codes and Adyen's API expectations.private function collectMethodCodeWithoutPrefix($methodCode): string { if ($methodCode == CreditCard::METHOD_CC) { - return 'card'; + return "scheme"; } return substr( $methodCode, strpos($methodCode, ProcessingMetadataInterface::METHOD_ADYEN_PREFIX) + strlen(ProcessingMetadataInterface::METHOD_ADYEN_PREFIX) ); }Steps to Reproduce the Issue
Expected Behavior
Credit card payment method should be available at checkout when properly configured in Adyen.
Root Cause
The mismatch between the identifier used in the code ("card") and the one expected by Adyen's API ("scheme") caused the credit card payment method to be incorrectly filtered out, even when it was properly configured.
This fix ensures that the correct identifier is used when checking if the credit card payment method is available according to Adyen's configuration.