Conversation
Execution is faster at first call (because no more regex compilation) and the wheel size is split in half (1Mo => 500ko).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilise un parser combinatoire (
nom), qui est plus rapide qu'un regex et réduit fortement la taille de l'exécutable, sans ajouter beaucoup de code.J'aurais pu écrire aussi le parser des dimensions à la main, mais ça aurait fait un plus gros volume de code. Utiliser le crate
nomest un bon compromis entre vitesse, taille de l'exécutable et quantité de code à écrire.