Fix/103 add support for next forecast by remark #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeharding
requested changes
Jan 2, 2025
Owner
aeharding
left a comment
aeharding
left a comment
There was a problem hiding this comment.
Looks good, mostly nits, I'm curious if you could try to get a RemarkDated type made for smarter types!
aeharding
reviewed
Jan 2, 2025
Owner
aeharding
left a comment
aeharding
left a comment
There was a problem hiding this comment.
The RemarkDated works great, thanks!
aeharding
approved these changes
Jan 2, 2025
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to parse the
NXT FCST BYremark often found in canadian TAFs. This effectively fixes #103