Added support for a value indicator for rvr range reports (fixes #117) #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi! Thanks for the PR. Corepack dropped the ball and broke the build so if you rebase on latest main and force push it should start working again. |
Contributor
Author
|
Did the rebase and marked it as draft for now. I want to do some validation to make sure that this was not just issued by error and is actually a use-case. |
Contributor
Author
|
Ok yeah I've confirmed it can happen (even if very rare) |
Contributor
Author
|
@aeharding you think you get a chance anytime soon to review, merge and release? I am getting ready to publish a new update for my site and would love to include it. |
Owner
|
I’ll be back from vacation next week. If I have time before I’ll check it out!On Feb 11, 2025, at 2:37 PM, Florian Krauthan ***@***.***> wrote:
@aeharding you think you get a chance anytime soon to review, merge and release? I am getting ready to publish a new update for my site and would love to include it.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#118 (comment)",
"url": "#118 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
Contributor
Author
|
Just checking in if this is still on your radar? |
Owner
|
Sorry, yes it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly parses
R08R/5000VP6000FT/Dand setting theindicatorfield (in the example case toValueIndicator.GreaterThan)This fixes #117