-
Notifications
You must be signed in to change notification settings - Fork 208
[BUG] fix links in estimator overview page #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- rename `/aeon/classification/_dummy.py` file for `all_estimators` function to properly get it's path - as a result, the link for `DummyClassifier` get's corrected in the **Estimator Overview** page
Thank you for contributing to
|
The problem with the last class is that it's documentation doesn't exist whatsoever. One fix would be changing the folder structure, I'm not sure though. Thank you! |
Is there a reason why it can't find estimators in the root of a module? Leaving it like this would prohibit us from formatting estimators like this in the future. Looks like an import has to be updated for the tests. |
@inclinedadarsh any issues with this? |
Oh hey, completely missed this one. Are you talking about the RocketGPU issue or the algorithm not being able to list files which are in the root directory? For the latter one, I'll clone it tomorrow and make a commit as soon as possible. As of now I believe I'll have to undo the file name changes and make some changes in the algorithm itself to detect files from the root directory. Sorry for the delay. |
For RocketGPU i think just add it to the transformers API page if that is the issue. Should be a quick fix. My main concern is the root directory one yes. Good catch on that. I would like to avoid having to make all the files private if possible. |
Hello, just a quick update I'm working on the GSoC proposal as of now, so it'll take some time. |
Reference Issues/PRs
Fixes #2474
What does this implement/fix? Explain your changes.
This pull request fixes the incorrect links in the Overview Estimator page in the documentations.
The issue was that the
all_estimators
function from theaeon.utils.discovery
module wasn't providing correct path to those classes mentioned in #2474 (comment)It turned out, that the those classes generally don't have a
**underscore**
in front of their file names. It's because they're not part of a sub module.For example, the
DummyClassifier
actual is a part of theclassification
module, but it's directly inside that, unlike the rest of the modules.To fix this, I thought of few ways, such as handling these cases in the code itself. However, the best was I think is simply adding a underscore in front of those files and also fixing the imports after that.
Following files will be fixed:
DummyClassifier
DummyClusterer
SeriesSearch
QuerySearch
RocketGPU
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
No
PR checklist
For all contributions
For developers with write access