-
Notifications
You must be signed in to change notification settings - Fork 208
[DOC] Add RotationForest Classifier Notebook for Time Series Classification #2592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
It would be good if you can include a reference for the original paper. It would also be good to talk about why it is relevant for TSC. Have a mention some of the algorithms which use the classifier (STC, FreshPRINCE). I would take a look at https://arxiv.org/pdf/1809.06705 also which discusses why RotF is good for continuous features (which time series will always be, and most approaches extract features as). |
@@ -0,0 +1,210 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think there is still more that can be added but fine for a first iteration. Please remove the extra cell at the end then LGTM
Reply via ReviewNB
It will be great to add more, Please tell me what else we can do. |
@@ -0,0 +1,210 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our implementation uses the sklearn decision tree which is CART i believe. I would include this in brackets maybe.
Dont need to bold, in the last line use RotationForestClassifier
.
I wouldnt say the second point is necessarily correct. The decision tree are built on the transformed/rotated features. You can use ChatGPT to find out more about the algorithm if that helps, just dont copy and paste the contents into the notebook. i.e. "When feature interactions and correlations are significant, Rotation Forest might capture these better through PCA rotations." is correct.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our implementation uses the sklearn decision tree which is CART i believe.
I took this information from the paper https://arxiv.org/pdf/1809.06705, it is mentioned in 3rd point.
III. THE ROTATION FOREST ALGORITHM
Rotation forest is a tree-based ensemble with some key
differences to random forest. The two main differences are
that rotation forest transforms the attributes into sets of
principle components, and that it uses a C4.5 decision tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not our implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have gone to the opposite end now, it is true that the original Rotation forest uses a C4.5 decision tree. It is only our implementation which uses the scikit-learn CART.
Nah lets just tidy this up for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Reference Issues/PRs
Fixes: #2383
What does this implement/fix? Explain your changes.
This PR adds a new notebook demonstrating the use of the RotationForest classifier.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access