-
Notifications
You must be signed in to change notification settings - Fork 208
[DOC] Inconsistent double ticks in segmentation package, public docstring only #2622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[DOC] Inconsistent double ticks in segmentation package, public docstring only #2622
Conversation
Thank you for contributing to
|
|
||
Attributes | ||
---------- | ||
merged_ : array_like | ||
2D `array_like` outlining which clusters were merged_ at each step. | ||
2D ``array_like`` outlining which clusters were merged_ at each step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think array_like applies here. It is not an actual structure such as list
or np.ndarray
. Seems like more of an umbrella for multiple types of input.
Reference Issues/PRs
#809
What does this implement/fix? Explain your changes.
Updated docstring of segmentation package using double back ticks as requested in #809
I purposely did not update methods' docstring of those same public classes that were preceded by an underscore (
_
) assuming them to be only for internal use. - e.g. I did updateHMMSegmenter
class docstring, but not its method_get_test_params()
as it is preceded by an underscore. I adopted this more conservative approach since it is easier to add new eventual commits in case admins of this repo change their mind about how to deal with this minor detail.By the way, assuming my approach as standard rule, during the docstring review I found some violation of this as some previous contributors used double backticks also for such private methods of public classes - e.g.
_get_neighbourhood_params
docstring in_hidalgo.py
at line 145-147 was written asI left also this untouched as it is still not clear whether such use of back ticks should be updated or not (anyway, as far as I remember, the example reported is the only case where such case happened in the segmentation package).
Does your contribution introduce a new dependency? If yes, which one?
None
Any other comments?
None
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access