[DOC] Inconsistent double ticks in segmentation package, public docstring only #2622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#809
What does this implement/fix? Explain your changes.
Updated docstring of segmentation package using double back ticks as requested in #809
I purposely did not update methods' docstring of those same public classes that were preceded by an underscore (
_
) assuming them to be only for internal use. - e.g. I did updateHMMSegmenter
class docstring, but not its method_get_test_params()
as it is preceded by an underscore. I adopted this more conservative approach since it is easier to add new eventual commits in case admins of this repo change their mind about how to deal with this minor detail.By the way, assuming my approach as standard rule, during the docstring review I found some violation of this as some previous contributors used double backticks also for such private methods of public classes - e.g.
_get_neighbourhood_params
docstring in_hidalgo.py
at line 145-147 was written asI left also this untouched as it is still not clear whether such use of back ticks should be updated or not (anyway, as far as I remember, the example reported is the only case where such case happened in the segmentation package).
Does your contribution introduce a new dependency? If yes, which one?
None
Any other comments?
None
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access