-
Notifications
You must be signed in to change notification settings - Fork 208
[DOC] Deep learning clustering notebook #2664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…g-based-clustering Deep learning based clustering
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
@MatthewMiddlehurst , @chrisholder , @TonyBagnall could you please review this pr. |
Can you please:
|
@aadya940 the scatter plots observation would be quite same for some of the them so should i add them as inference if same for both. |
@Edgeshot27 Yes. |
@aadya940 i have made the changes kindly please review again |
@Edgeshot27 Last few changes,
|
@aadya940 i have made the necessary changes. |
@aadya940 are the changes okay now. |
LGTM! |
@aadya940 is the request approved now |
@@ -0,0 +1,781 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,781 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,781 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these plots intending to show? creating a scatter of the first two time series values does not seem very useful. The gradient bar does not seem useful either. I would check out the visualisation module for some ideas what to plot.
Reply via ReviewNB
@@ -0,0 +1,781 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,781 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference Issues/PRs #2283
What does this implement/fix? Explain your changes.
This notebook presents six deep learning clustering models with detailed explanations, code examples, and visualizations:
Each model section explains its architecture, sample code implementation, and visualized clustering results to aid user understanding.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access