Use relocation for bundled dependencies#146
Open
sonOfRa wants to merge 2 commits into
Open
Conversation
Author
|
CC @dmeyerholt |
Author
|
I'll take a look if this is still needed soon, when I have some downtime. Probably around the end of december. Thanks for the reminder! |
|
@sonOfRa could you resolve merge conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We use keycloak-metrics-spi alongside with another custom SPI that uses prometheus libraries at runtime - this worked fine in the WildFly distribution, but on the Quarkus distribution, there is no classloader isolation between SPIs - all classes are shared. This lead to some ugly clashes, which we want to prevent by relocating all SPIs that use dependencies that aren't present on the Keycloak classpath by default.
What
Configures the maven-shade-plugin to relocate dependencies, and uses the gradle-shadow-plugin to relocate them in the gradle build
Why
The lack of classloader isolation in the Keycloak Quarkus distribution caused clashes between different SPIs that have dependencies
A small before and after of how the jars look on the inside:
BEFORE:
AFTER: