Add maven wrapper and utf-8 standard encoding#206
Open
jannickherrmann wants to merge 2 commits into
Open
Conversation
Contributor
|
@jannickherrmann thanks, I can confirm that the wrapper works (after marking the script as executable) |
Contributor
Author
|
@pb82 thanks for the comment, i made the wrapper for unix/mac systems executable by default and pushed it. works on windows maschines |
ad89e7f to
bf5ddf1
Compare
|
@jannickherrmann could you update the PR and resolve merge conflicts? |
- set utf-8 to default encoding
bf5ddf1 to
80d1d01
Compare
Contributor
Author
|
@alexted Thanks for the feedback! I've updated the PR and resolved the merge conflicts. Let me know if there's anything else you'd like me to adjust. |
|
@pb82 сould you pay attention to this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To ensure platform independence for Maven builds and to align with best practices for encoding standards.
Relates to: #205
What
Added Maven wrapper and set UTF-8 as default encoding.
Why
To make the build process more consistent across different platforms and to avoid encoding-related issues.
How
Verification Steps
Checklist:
Progress
Additional Notes
No additional notes.