This repository was archived by the owner on Mar 9, 2023. It is now read-only.
fix: pass ouiaId to select fields#120
Open
gashcrumb wants to merge 1 commit into
Open
Conversation
This change updates the SelectField to also supply the ouiaId property to the underlying patternfly select component. This ensures that the select field has a suitable identifier for automated tests, as the `id` property is currently applied to an element that isn't initially visible or selectable.
Author
|
Hi, anyone around to have a look at this? |
Contributor
|
Hey @gashcrumb, thanks for the input! @ljmotta is busy migrating this project to another org, since it's primarily used there and the aerogear projects that were using this are no longer being maintained. @ljmotta Do you think there would be any merit adding this as a last feature before the migration? Or would this be something you would consider adding to the new repo? |
Contributor
|
Hi @gashcrumb, please see #122. This repo has now been fully moved across to kie-tools. Maintenance for the package will also imporve now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the SelectField to also supply the ouiaId property to the underlying patternfly select component. This ensures that the select field has a suitable identifier for automated tests, as the
idproperty is currently applied to an element that isn't initially visible or selectable.If this works would it be possible to get a release with this fix?