Skip to content

Config annotation updates - #1994

Draft
nbradac wants to merge 9 commits into
masterfrom
config-annotation-updates
Draft

Config annotation updates#1994
nbradac wants to merge 9 commits into
masterfrom
config-annotation-updates

Conversation

@nbradac

@nbradac nbradac commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread aeron-annotations/src/main/java/io/aeron/config/validation/Validator.java Dismissed
Comment thread .github/workflows/config-doc.yml Outdated
Comment thread .github/workflows/config-doc.yml Outdated
Comment thread .github/workflows/config-doc.yml Outdated
@@ -0,0 +1,44 @@
name: Config Documentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the idea behind this workflow? Who will be checking/consuming generated artifacts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I had put together this whole @config annotation a couple years ago, but never really polished it up. The dream was to have some way to generate all our configuration documentation based on the source code, and to have it produce the doc for Java and for C. In some futuristic world, we'd run this workflow when we release Aeron, so as to provide a nice big document with all the configuration options in one place.

Comment on lines +20 to +23
/**
* Converts Javadoc markup (inline tags, HTML) in description strings to Markdown equivalents,
* and strips block Javadoc tags such as {@literal @}return, {@literal @}param, etc.
*/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) So... one of the reasons I revisted this after 2 years was that it seemed like a reasonable project against which to kick the tires of Claude. When I asked it to build me something that would sanitize the javadoc to make it more fitting for a .md file, this is what it came up with. I know there's no HTML in our javadoc, but it didn't seem like it was hurting anything to leave in the code it came up with.

Comment thread build.gradle Outdated
@vyazelenko

Copy link
Copy Markdown
Contributor

@nbradac Have you looked at the https://github.com/asciidoctor/asciidoclet?

@vyazelenko

Copy link
Copy Markdown
Contributor

@nbradac

nbradac commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

The other thing that is still TODO is the contents of the CDriverConfiguration class. All that javadoc was generated by Claude, and it... did a terrible job. It mentions java objects all over the place.

@nbradac
nbradac marked this pull request as ready for review April 13, 2026 23:58
@vyazelenko
vyazelenko marked this pull request as draft June 30, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants