fix(c): ignore missing properties files in aeron_properties_file_load - #2088
Open
devansh-dek wants to merge 1 commit into
Open
fix(c): ignore missing properties files in aeron_properties_file_load#2088devansh-dek wants to merge 1 commit into
devansh-dek wants to merge 1 commit into
Conversation
Match the Java driver behaviour: a non-existent properties file is a no-op rather than a fatal error. Other open failures still report an error. Fixes aeron-io#1124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The C media driver failed to start when a properties file path did not exist, while the Java driver silently skips missing files via
SystemUtil.loadPropertiesFiles. This aligns C with Java by treatingENOENTfromfopenas a no-op inaeron_properties_parse_file.Other open failures (permissions, etc.) still return an error.
Test plan
properties_testtarget./binaries/properties_test --gtest_filter=DriverConfigurationTest.shouldIgnoreMissingPropertiesFileFixes #1124
Made with Cursor