test: cover aeron cluster context defaults - #2091
Open
amirdeljouyi wants to merge 1 commit into
Open
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added two small tests around context state that is easy to regress but was not directly covered before. They check that cloned contexts preserve configured values and that
runAgentInvokers()invokes both the Aeron conductor invoker and the configured context invoker.Impact on coverage:
AeronCluster.Contextcloning, timeout/directory/invoker state, and combined agent-invoker execution, including AeronCluster.java:1439-1444 and AeronCluster.java:2073-2089.AeronClusterincreases by around 3%.Why:
I hope you find these tests useful. 😄 Please let me know if you have any questions or concerns.
Thanks,
Amir