Retry MaxErrorRateExceeded under concurrent segment appends - #28
Merged
Conversation
Relax default client error-rate limits and extend overload backoff so high-concurrency append_event load survives transient DeviceOverload bursts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaxErrorRateExceededalongsideDeviceOverloadin segment write andbatch_writepathsmax_error_rate/error_rate_windowinmake_client()so stress workloads on a single CE node do not trip the client circuit breaker immediatelyContext
Heavy concurrent
append_eventload (e.g. 64 writers on one session) against Docker CE can briefly returnDeviceOverload, which cascades intoMaxErrorRateExceededwith the stock client defaults. Segment rollover itself is fine — this is client/back-pressure resilience.Test plan
pytest tests/test_sessions.py::test_concurrent_append_flushes_under_write_block_sizepytestfull suite