Skip to content

Remove deprecated third argument to BCrypt::Engine.hash_secret #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harelsafra wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecated third argument to BCrypt::Engine.hash_secret #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/aerospike/command/login_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,10 @@ def authenticate_via_token(conn, cluster)

SALT = '$2a$10$7EqJtq98hPqEX7fNZaFWoO'
def self.hash_password(password)
# Hashing the password with the cost of 10, with a static salt
return BCrypt::Engine.hash_secret(password, SALT, :cost => 10)
# Hashing the password with a static salt. The cost (10) is already
# encoded in SALT, so the third argument to hash_secret is redundant
# and has been removed (bcrypt >= 3.1.19 deprecates passing it).
return BCrypt::Engine.hash_secret(password, SALT)
end
end
end
Expand Down