Skip to content

add path to endpoint.ex in installation guide for Phoenix 1.7 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add path to endpoint.ex in installation guide for Phoenix 1.7 #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ Follow the instructions at https://hexdocs.pm/phoenix_view/Phoenix.View.html

You will also need to change `helpers: false` to `true` as shown in example below.
```elixir
# in your lib/you_app_web/endpoint.ex
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Don't know how the filename wasn't mentioned here!
Just to be consistent with the rest of the docs, since we're using "my app" instead of "your app", could you please make this lib/my_app_web.ex and it'll be ready to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh my bad =D

def router do
quote do
use Phoenix.Router, helpers: true
Expand Down