refactor: promisify instead promisify-child-process #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
promisify-exec
branch
from
8d2e2ad to
56e2024
Compare
thepiwo
approved these changes
Dec 22, 2024
davidyuk
force-pushed
the
promisify-exec
branch
from
56e2024 to
d73116d
Compare
davidyuk
force-pushed
the
promisify-exec
branch
from
d73116d to
0b7a791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supported by the Æternity Foundation
Implemented according to NodeJS guide https://nodejs.org/api/child_process.html#child_processexeccommand-options-callback
https://nodejs.org/api/child_process.html#child_processspawncommand-args-options
https://www.npmjs.com/package/promisify-child-process