-
Notifications
You must be signed in to change notification settings - Fork 0
chore: migrate to mise #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to af9383c in 58 seconds. Click for details.
- Reviewed
51lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/test.yml:12
- Draft comment:
Ensure 'mise install' correctly sets up the Go environment per .mise.toml. Verify that the version installed is what's expected. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to verify that the setup is correct and that the version installed is as expected. This falls under the category of asking the author to double-check things, which is against the rules.
2. .github/workflows/test.yml:6
- Draft comment:
Matrix strategy was removed. Confirm that testing against a single Go version meets your requirements. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. .mise.toml:2
- Draft comment:
Confirm that using Go version '1.25.5' aligns with your project needs and is compatible with tooling changes. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_KY2locszyYeZHEX4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
af9383c to
8cbff6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 8cbff6f in 54 seconds. Click for details.
- Reviewed
55lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/test.yml:12
- Draft comment:
Ensure the removal of setup-go and matrix config is intentional; confirm that 'mise' correctly sets the required Go version for all jobs. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. .mise.toml:1
- Draft comment:
Verify that Go version 1.25.5 is compatible with your codebase and CI requirements. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_ishfNl7aUxGW11Pf
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
8cbff6f to
f79f9db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed f79f9db in 2 minutes and 50 seconds. Click for details.
- Reviewed
59lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/test.yml:6
- Draft comment:
Removed matrix and setup-go steps now fix Go to version from .mise.toml (1.25.5). Confirm that testing on a single Go version is intended. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm their intention regarding testing on a single Go version. This violates the rule against asking the author to confirm their intention or ensure behavior is intended. The comment should be removed.
2. .github/workflows/test.yml:21
- Draft comment:
There are duplicate calls to 'mise reshim' (once as a dedicated step and again in the run blocks). Verify if both are needed to update shims for binaries installed via 'go install'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment starts with "Verify if both are needed" which is explicitly mentioned in the rules as a type of comment to avoid ("Do NOT ask the PR author to confirm their intention, to explain, to double-check things, to ensure the behavior is intended"). The comment doesn't definitively state that one of the reshim calls is unnecessary - it's speculative and asks for verification. While there may be duplication, the comment doesn't provide clear evidence that this is wrong or actionable guidance on what to change. The first reshim might be needed after mise install, and the second after go install - this could be intentional. Perhaps the duplication is genuinely problematic and wasteful, and the comment is trying to help optimize the workflow. The author might not have realized they're calling reshim twice and this could be a legitimate code quality issue. Even if the duplication might be suboptimal, the comment explicitly asks to "verify if both are needed" rather than stating definitively that one should be removed. This is asking the author to confirm their intention, which violates the rules. If the comment had said "Remove the duplicate reshim call on line X because Y", that would be actionable. This comment should be deleted because it asks the PR author to verify their intention rather than providing clear, actionable guidance. It's speculative about whether both calls are needed, rather than definitively identifying an issue.
3. .mise.toml:1
- Draft comment:
The new .mise.toml fixes Go to version 1.25.5. Ensure that upgrading from earlier versions (e.g. 1.16.x or 1.24.x) does not break compatibility with your project. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to ensure compatibility with the new Go version, which violates the rule against asking the author to ensure behavior is intended or tested. It does not provide a specific suggestion or point out a specific issue.
Workflow ID: wflow_eu8WkrQcUPSLLMcq
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Important
Migrates CI workflow to use
misefor tool installation and management, adding.mise.tomlfor configuration.misein.github/workflows/test.yml.misebefore running tests and tidy checks..mise.tomlto specify Go version1.25.5.This description was created by
for f79f9db. You can customize this summary. It will automatically update as commits are pushed.