Adding markers to datalog plotting#5
Open
scatwang wants to merge 5 commits into
Open
Conversation
Owner
|
Nice addition. At the moment both the backend (plot.ts) removes data rows after PLOT_MAX_ROWS I do not see any memory conservation / cleanup for the markers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the plotting system to automatically add a visual marker to the chart when it detects the log message pattern
plot: marker: marker_namein stdout.The primary benefit is to provide users with immediate, context-specific annotations on the data, significantly aiding data analysis and interpretation.