-
-
Notifications
You must be signed in to change notification settings - Fork 37.5k
feat(hooks): opt-in skill router with evaluation (split from #2788) #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
montjeffrey
wants to merge
12
commits into
affaan-m:main
Choose a base branch
from
montjeffrey:feat/skill-router
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
af403cd
feat(plugins): generate slim profile plugins from selective-install m…
montjeffrey 8bfd1f1
fix(plugins): address profile-plugin review findings
montjeffrey 1c58cef
feat(hooks): add skill-router prompt hook and /plugin-profiles command
montjeffrey e0e02bb
fix(hooks): harden skill-router per review findings
montjeffrey 61f3baa
chore: sync catalog counts and command registry for /plugin-profiles
montjeffrey 483d3fe
fix(plugins): close review findings on profile plugins and skill router
claude abfd71e
Merge branch 'main' into feat/profile-plugins
montjeffrey 1e1b03b
Merge remote-tracking branch 'upstream/main' into feat/profile-plugins
montjeffrey 18919a4
chore: sync catalog counts after merging main
montjeffrey 9a6d3cd
feat(plugins): fail-closed, receipted, self-contained profile carriers
montjeffrey d4e2007
feat(hooks): skill router as an opt-in, bounded, evidenced adapter
montjeffrey 07b37e7
fix(router): enforce budget during catalog scan, not just after it
montjeffrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -220,6 +220,7 @@ commands: | |
| - plan | ||
| - plan-canvas | ||
| - plan-prd | ||
| - plugin-profiles | ||
| - pm2 | ||
| - projects | ||
| - promote | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| --- | ||
| description: Generate and manage slim ECC profile plugin carriers - list profiles, plan the listing ledger and capability decision, generate a receipted plugin, and activate it per project. | ||
| argument-hint: "[list | plan <profile> | generate <profile> | activate <plugin-name>]" | ||
| --- | ||
|
|
||
| # Plugin Profiles Command | ||
|
|
||
| Manage slim ECC profile plugin carriers from inside Claude Code. A carrier is | ||
| a standalone plugin generated from an install selection: it lists only the | ||
| selected skills, agents, and commands, keeps the rest of the skill catalog | ||
| reachable on demand inside the plugin, and records how it was built in | ||
| `ecc-profile.json`. See `docs/PLUGIN-PROFILES.md` for the underlying tool. | ||
|
|
||
| Run every command below from the ECC plugin root (`${CLAUDE_PLUGIN_ROOT}` when | ||
| set, otherwise the everything-claude-code checkout). | ||
|
|
||
| ## Subcommands | ||
|
|
||
| ### `/plugin-profiles list` | ||
|
|
||
| Run `node scripts/plugin-profiles.js list` and show the available install | ||
| profiles with their module counts. | ||
|
|
||
| ### `/plugin-profiles plan <profile>` | ||
|
|
||
| Run `node scripts/plugin-profiles.js plan --profile <profile>` and report: | ||
|
|
||
| - the context selection (skills, agents, commands) and the token ledger with | ||
| its method label and budget verdict; | ||
| - the capability selection: whether the hook runtime is off, enabled at a | ||
| profile, or still needs a decision. | ||
|
|
||
| If the plan says a hook decision is required, ask the user whether to carry | ||
| the hook runtime (`--hooks minimal|standard|strict`) or not (`--hooks off`) | ||
| before offering to generate. Never choose for them. | ||
|
|
||
| ### `/plugin-profiles generate <profile>` | ||
|
|
||
| 1. Run `node scripts/plugin-profiles.js generate --profile <profile> --dry-run` | ||
| first and show the target path, whether an existing directory would be | ||
| replaced, the ledger, and any blockers. | ||
| 2. If the dry run lists blockers, resolve them with the user: a hook decision | ||
| (`--hooks ...`), an over-budget ledger (`--budget <n>` or | ||
| `--allow-over-budget`), or a target that is not an unmodified generated | ||
| carrier (`--force`, only with explicit confirmation). | ||
| 3. Run the real `generate` with the agreed flags and show the generated path, | ||
| the receipt digests, and the printed next steps. | ||
| 4. Offer the activation step below. | ||
|
|
||
| Pass through extra flags the user asks for (`--name`, `--out`, `--modules`, | ||
| `--with`, `--without`, `--no-catalog`, `--keep-prev`). | ||
|
|
||
| ### `/plugin-profiles activate <plugin-name>` | ||
|
|
||
| Offer to write the per-project opt-in to `.claude/settings.json` in the | ||
| current project: | ||
|
|
||
| ```json | ||
| { | ||
| "enabledPlugins": { | ||
| "ecc@ecc": false, | ||
| "<plugin-name>@ecc-profiles": true | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| Merge with any existing `enabledPlugins` block instead of overwriting the | ||
| file. ALWAYS show the resulting JSON and get user confirmation before | ||
| writing - never change plugin activation silently. Remind the user the | ||
| change takes effect on the next session. | ||
|
|
||
| ## Notes | ||
|
|
||
| - Custom selections work too: `generate --modules commands-core --with skill:react-patterns`. | ||
| - Regenerate after updating ECC: the carrier is a snapshot, not a live link. | ||
| - The generated `ecc-catalog` skill indexes the full catalog with paths inside | ||
| the carrier (`on-demand/<skill>/SKILL.md`), so nothing outside the plugin is | ||
| ever referenced. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds and registers
/plugin-profilesas a new primary workflow without a migration or cross-harness compatibility need, expanding the legacy command catalog instead of placing the workflow on the repository's canonical skills-first surface.File Used:
AGENTS.md(source)Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!