#106: Switch resource drop to non-blocking versions #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiffon
force-pushed
the
106-change-async-drop-behavior
branch
2 times, most recently
from
407c2ed to
1d4c178
Compare
afiffon
force-pushed
the
106-change-async-drop-behavior
branch
from
1d4c178 to
50be631
Compare
cjbradfield
reviewed
Aug 7, 2025
fmt: normalize (Internal):\n\n comments
cjbradfield
reviewed
Aug 7, 2025
Contributor
cjbradfield
left a comment
cjbradfield
left a comment
There was a problem hiding this comment.
Since we're keeping the atomics, just a few changes to the Ordering and a nit on preferring exchange to compare_exchange since you definitely want to set open to false.
Add debug assertions for the case. due to latest changes in how closing work, this issue raised and broke tests.
afiffon
force-pushed
the
106-change-async-drop-behavior
branch
from
d273f9a to
61c27d4
Compare
cjbradfield
approved these changes
Aug 7, 2025
cjbradfield
added a commit
to cjbradfield/smb-rs
that referenced
this pull request
Aug 7, 2025
Remove changes to Resource since those are handled in afiffon#108 and in smb_client as implementing Drop on the above solves the problem more effectively.
afiffon
force-pushed
the
106-change-async-drop-behavior
branch
2 times, most recently
from
5facc54 to
605764a
Compare
Relaxed order instead of SeqCst in `ResourceHadnle::open`
afiffon
force-pushed
the
106-change-async-drop-behavior
branch
from
605764a to
e819678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for
Resourceonly, since resource is the most instantiated structure that causes this issue.In the future, if needed, the same technique can be applied to connection, session, and tree.