Skip to content

Conversation

@afiffon
Copy link
Owner

@afiffon afiffon commented Sep 5, 2025

No description provided.

Add docs for threading models + main page, and for some structs as well
rename set_file_info to set_info, rename query_directory to query
@afiffon afiffon linked an issue Sep 5, 2025 that may be closed by this pull request
@afiffon afiffon requested a review from Copilot September 5, 2025 14:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the SMB object drop/close behavior to make resource management more explicit and improve safety. The changes remove mutable requirements from clients and handlers while ensuring proper cleanup of SMB resources.

  • Removes mutable references from client and connection methods
  • Refactors tree disconnect behavior to use atomic operations
  • Standardizes method naming (e.g., set_file_infoset_info)

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
smb/tests/*.rs Updated to use immutable client references and renamed API methods
smb/src/tree.rs Major refactoring of tree disconnect logic with atomic operations
smb/src/session.rs Updated session management with atomic boolean for drop state
smb/src/resource/*.rs Renamed set_file_info to set_info for consistency
smb/src/connection.rs Removed mutable requirements and improved connection management
smb/src/client/*.rs Refactored to use immutable references and improve DFS handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Add tests
update and add docs; fix docs to run in async only
@afiffon afiffon force-pushed the 122-review-and-fix-dropclose-of-smb-objects branch from 2620e3b to a55c38e Compare September 5, 2025 14:53
@afiffon afiffon merged commit c592ada into main Sep 5, 2025
4 checks passed
@afiffon afiffon deleted the 122-review-and-fix-dropclose-of-smb-objects branch September 12, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review and fix drop/close of SMB objects

2 participants