Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- name: 馃攳 Qodana Scan
id: qodana
uses: JetBrains/qodana-action@v2026.1.3
uses: JetBrains/qodana-action@v2026.2.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃攳 Cache keys still reference Qodana 2025.3 while action moves to 2026.2.0

The Qodana step's primary-cache-key/additional-cache-key (.github/workflows/code-quality.yml:38-39) are hardcoded to qodana-2025.3-..., which no longer matches the action version being used (now 2026.2.0). This is pre-existing (the keys were already stale for 2026.1.3), but the bump makes it more misleading: caches produced by different Qodana major versions share the same key, which can lead to reusing incompatible cache contents. Consider parameterizing the version in the cache key.

Open in Devin Review

Was this helpful? React with 馃憤 or 馃憥 to provide feedback.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃攳 New action release changes exit-code propagation semantics

The 2026.2.0 release notes include "QD-13746 pass Qodana exit code in action" and "QD-15410 check that in case of pr-mode: true the repository checked out to source branch". The step uses continue-on-error: true (.github/workflows/code-quality.yml:31) so a newly propagated non-zero exit (with --fail-threshold 0) won't fail the job, but steps.qodana.outcome semantics may change for any downstream consumers. The checkout step also pins ref: ${{ github.event.pull_request.head.sha }} rather than the source branch, which could interact with the new pr-mode branch check if pr-mode is ever enabled.

Open in Devin Review

Was this helpful? React with 馃憤 or 馃憥 to provide feedback.

continue-on-error: true
env:
QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
Expand Down
Loading