fix: unblock the v4.0.0 release (Windows build + clippy 1.96)#262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v4.0.0 release run failed on
publish-winand the Lint CI was red. This branch fixes both so v4.0.0 can be cut cleanly.What's fixed
publish-win→Build win64):build.rsinvokespnpm, but on Windows the mise shims aren't on PATH, so the frontend build failed (failed to run pnpm: program not found). Now each publish job buildssetup-uiin a dedicated step viamise exec -- pnpm(shim-independent) and setsDISCRAKT_SKIP_UI_BUILD=1so the cargo build reuses the prebuiltdist/. Applied to linux/win/macos for consistency.stablerolled to 1.96.0, whoseunnecessary_sort_bylint flagged pre-existingplex_auth.rs. Fixed viasort_by_key.rust-toolchain.tomlpinning 1.96.0 so local and CI clippy stay in sync.update-winget/update-homebrewnow skip pre-releases, so beta tags can dress-rehearse the build without touching package managers.Validated locally:
mise exec -- pnpm run buildproducesdist/,DISCRAKT_SKIP_UI_BUILD=1 cargo buildreuses it, clippy/fmt/tests clean on 1.96.0, actionlint clean.