ci(release): drop redundant target inputs and guard the setup-ui build#263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge cleanups from the review of the v4.0.0 release fixes. Both are zero-risk to the build (v4.0.0 already shipped green with the underlying behavior).
targets:inputs on the linux/macosInstall Ruststeps. Withrust-toolchain.tomlpinning the toolchain, those inputs added targets to the unusedstabletoolchain; the explicitrustup target addsteps (added in the v4.0.0 fix) are what actually put the cross targets on the pinned toolchain. Thetargets:lines were dead and misleading — removed so there's one source of truth.test -f dist/index.html. Sincedist/is embedded at compile time viainclude_dir!, a build that produced no output would otherwise fail deep inside a macro instead of loudly at the build step. Cheap insurance.actionlint clean. No behavior change to the green release path.