Allow dash in component instance id like bind__troika-text - #822
Merged
Conversation
Member
|
Thank you! |
vincentfretin
added a commit
to 3DStreet/3dstreet
that referenced
this pull request
Apr 15, 2026
Backport from aframevr/aframe-inspector#822 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use https://github.com/supermedium/superframe/tree/master/components/state
so I entered
troika-textwhen adding thebindcomponent, but it wrongly createdbind__troikatextinstead ofbind__troika-textand so the bind component didn't work.A dash in component instance id is allowed.
This PR fixes the issue @dmarcos