Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller property for Oculus Quest #4567

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update controller property for Oculus Quest #4567

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7084a3
Update controller property for Oculus Quest
binzume May 2, 2020
68d1d68
Reset model offset
binzume May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/oculus-touch-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ var CONTROLLER_PROPERTIES = {
'oculus-touch-v2': {
left: {
modelUrl: TOUCH_GEN2_CONTROLLER_MODEL_BASE_URL + 'gen2-left.gltf',
rayOrigin: {origin: {x: -0.01, y: 0, z: -0.02}, direction: {x: 0, y: -0.5, z: -1}},
modelPivotOffset: new THREE.Vector3(0, 0, 0),
rayOrigin: {origin: {x: 0, y: 0, z: 0}, direction: {x: 0, y: 0, z: -1}},
modelPivotOffset: new THREE.Vector3(0.01, 0.005, 0.03),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the model position need to be adjusted? I thought the problem was only with the ray position.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the model is slightly out of position. I adjusted the offset so that the model position does not change when entering/leaving VR.
However it is only tested on my Oculus Quest, so I'll also consider to reset the change.

Copy link
Member

@dmarcos dmarcos May 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to separate changes and put the model shift in a different PR if necessary. I still think that for the rayOrigin we should probably use InputSource values instead of hard coding numbers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late, I reverted the change for model shift.
Also, it seems that XRInputSource.targetRaySpace has already been applied to the pose of controllers. https://github.com/aframevr/aframe/blob/master/src/components/tracked-controls-webxr.js#L115 So rayOrigin and direction may not be needed if XRInputSource is available.

modelPivotRotation: new THREE.Euler(0, 0, 0)
},
right: {
modelUrl: TOUCH_GEN2_CONTROLLER_MODEL_BASE_URL + 'gen2-right.gltf',
rayOrigin: {origin: {x: 0.01, y: 0, z: -0.02}, direction: {x: 0, y: -0.5, z: -1}},
modelPivotOffset: new THREE.Vector3(0, 0, 0),
rayOrigin: {origin: {x: 0, y: 0, z: 0}, direction: {x: 0, y: 0, z: -1}},
modelPivotOffset: new THREE.Vector3(-0.01, 0.005, 0.03),
modelPivotRotation: new THREE.Euler(0, 0, 0)
}
}
Expand Down