-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Post-Process example #5648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-Process example #5648
Conversation
Where does all those 1087 lines of code comes from? |
Yes, thanks for pointing that, I completely missed the new feature of A-Frame to use importmap. Sorry for that, I've reduced the bloom.js to the bare minimum to work. |
That new importmap example exist since 2 days ago ;) I'm glad I did it so we can have a simpler example here without copying all the code. |
Didn't we agree from supermedium/three.js#20 to use |
Whatever yields 90fps with the simpler code and least amount of dependencies |
pmndrs does not work in VR at the moment. I have opened tickets there, but at the moment no one is working on it. |
Typo Co-authored-by: Noeri Huisman <[email protected]>
deleted useless tick function Co-authored-by: Noeri Huisman <[email protected]>
I merged THREE changes and updated A-Frame so should work on top of master. Can you put the examples under Thanks so much for all the effort |
Co-authored-by: Vincent Fretin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the enabled prop in bloom component. You can use it in effect-controls
Co-authored-by: Vincent Fretin <[email protected]>
Co-authored-by: Vincent Fretin <[email protected]>
One more nit and ready to go: |
@@ -0,0 +1,36 @@ | |||
import AFRAME from 'aframe'; | |||
AFRAME.registerComponent('effect-controls', { | |||
schema: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the file uses 4 spaces indentation instead of 2
FYI. Linter should not let you commit if everything working as expected in your local setup |
yeah yeah, my bad, too many different projects with different setups. I usually run |
@vincentfretin looks we don't have (lost?) indentation rules? |
Thanks so much and for the patience. Usually first contributions don't get so involved 😄 Thanks for sticking to it and congrats |
Thanks to you and this wonderful community. I use A-Frame extensively, it seems to me fair to return something back to the community. |
Hi all, congrats on this fantastic work. I had been trying to get depth of field (bokeh) working with a-frame for... several years! Now it does, and on top of the bloom effect example (both running together): https://jywarren.github.io/sfpc/blur Just wanted to say thanks! ![]() I'm going to try to get volumetric lighting / god rays working next, although seems that'll be a bigger challenge as i haven't seen an EffectComposer-based example of that yet, so it'll be more involved. |
Has this been tested on other VR devices such as PCVR and AVP? |
It works on a smartphone-based Google Cardboard. I don't have other VR devices to test on. But it's smooth on a Pixel 6a in stereo mode with both effects enabled, for what it's worth. I did file an issue - #5677 about screenshots as well. |
Description:
Minimal example to show the possibility of implementing Post-Processing in A-Frame.
NOTE: for Post-Processing to work also in VR mode, supermedium/three.js#20 must be implemented in supermedium three.
Changes proposed:
-index.html running a simple scene with simple geometries with and without emission
-bloom.js, a minimal implementation of Bloom effect