Edit initWithUrl fun to use functional programming in (proInitWithUrl) function #161
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for contributing to this project. This is your first pull request and we are so glad to have you onboard. We will review the request and get back to you soon. We love your contributions! Join our Discord community here to discuss this PR or ask questions.
| @@ -102,6 +103,46 @@ class PdfRendererView @JvmOverloads constructor( | |||
| }) | |||
| } | |||
|
|
|||
| fun proWithUrl( | |||
There was a problem hiding this comment.
What is proWithUrl? Mind adding comments and improve naming.
There was a problem hiding this comment.
Updated version of initWithUrl fun.
Just pass to it function types as a @param.
There was a problem hiding this comment.
I am still confused with the naming.
|
Hi, would you mind cleaning up your PR and rebasing please. Thank you! |
|
I will fix the naming issue
…On Sun, Apr 20, 2025, 00:50 Rajat Mittal ***@***.***> wrote:
Hi, would you mind cleaning up your PR and rebasing please. Thank you!
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2XXFUJBEK27OZ4Q3322LHMTAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWHA4TIMZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*afreakyelf* left a comment (afreakyelf/Pdf-Viewer#161)
<#161 (comment)>
Hi, would you mind cleaning up your PR and rebasing please. Thank you!
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2XXFUJBEK27OZ4Q3322LHMTAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWHA4TIMZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Please remove |
|
Ok. Done
…On Mon, Apr 21, 2025, 20:16 Rajat Mittal ***@***.***> wrote:
Please remove .idea from your committed changes as well.
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2NHLTASNLYIGBNDI322UYWRAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJZGE4DGNZXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*afreakyelf* left a comment (afreakyelf/Pdf-Viewer#161)
<#161 (comment)>
Please remove .idea from your committed changes as well.
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2NHLTASNLYIGBNDI322UYWRAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJZGE4DGNZXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hey @ahmedfolly, I still see .idea files and conflicts in your commit. Can you please exclude them and resolve them? Thank you! |
Using functional programming in the initWithUrl function handles the states of downloading pdf easily, and makes the code of this function easy to understand.