Fix: Handle non-UTF-8 headers in Kafka/Confluent message parsing #2459
+26
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nikita Veselenko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
github-actions
bot
added
Confluent
|
@Bazarovinc Please look at this #2214 issue as well and add comprehensive tests. |
|
@draincoder Here’s a preliminary implementation for handling Kafka message headers. Please review and let me know if this approach looks good or if any adjustments are needed. |
Sehat1137
requested changes
Sep 6, 2025
Comment on lines
+34
to
+36
| headers.get("reply_to"), | ||
| headers.get("content-type"), | ||
| headers.get("correlation_id"), |
There was a problem hiding this comment.
what does headers.get return? Can you show example or write type?
| reply_to=headers.get("reply_to", ""), | ||
| content_type=headers.get("content-type"), | ||
| reply_to=headers.get("reply_to").decode() | ||
| if "content-type" in headers |
There was a problem hiding this comment.
content-type -> reply_to
Comment on lines
+79
to
+88
| reply_to=headers.get("reply_to").decode() | ||
| if "content-type" in headers | ||
| else None, | ||
| content_type=headers.get("content-type").decode() | ||
| if "content-type" in headers | ||
| else None, | ||
| message_id=f"{first.offset()}-{last.offset()}-{first_timestamp}", | ||
| correlation_id=headers.get("correlation_id"), | ||
| correlation_id=headers.get("correlation_id").decode() | ||
| if "correlation_id" in headers | ||
| else None, |
There was a problem hiding this comment.
What do u this about this way for better readable:
reply_to=headers.get("reply_to", b"").decode() or None
content_type=headers.get("content-type", b"").decode() or None
correlation_id=headers.get("correlation_id", b"").decode() or None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the UnicodeDecodeError that occurred when processing Kafka messages containing headers with non-UTF-8 byte sequences
Fixes #2458, FIxes #2214
Type of change
Checklist
just lintshows no errors)just test-coveragejust static-analysis