Skip to content

Conversation

borisalekseev
Copy link
Collaborator

@borisalekseev borisalekseev commented Sep 29, 2025

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (just lint shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running just test-coverage
  • I have ensured that static analysis tests are passing by running just static-analysis
  • I have included code examples to illustrate the modifications

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 29, 2025
@Lancetnik Lancetnik requested a review from Sehat1137 October 2, 2025 07:11
Copy link
Member

@Lancetnik Lancetnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move code examples to separated files in docs/docs_src, write tests for them and apply ruff checks


#### Accessing context fields

**HTTP** endpoints can receive arguments from the context, such as **App**, **Logger**, **Context**, or **Request** objects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add link to Context documentation section

**HTTP** endpoints can receive arguments from the context, such as **App**, **Logger**, **Context**, or **Request** objects.

```python linenums="1" hl_lines="7 15"
from faststream.annotations import Logger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just faststream.Logger

@Sehat1137 Sehat1137 closed this Oct 6, 2025
@Sehat1137 Sehat1137 reopened this Oct 6, 2025
@Sehat1137 Sehat1137 closed this Oct 7, 2025
@Sehat1137 Sehat1137 reopened this Oct 7, 2025
@Sehat1137 Sehat1137 closed this Oct 13, 2025
@Sehat1137 Sehat1137 reopened this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants