-
Notifications
You must be signed in to change notification settings - Fork 71
Register extension from web UI #2230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dgdavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lslezak!
To be honest, I'm not completely sure how this will look when we have a bunch of extensions, but it definitely seems like a very good starting point to me.
That said, I’ve left a few comments that I think could help refine it a bit more before releasing a first iteration.
Hope it helps.
lslezak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DBus error
| export default function ProductRegistrationPage() { | ||
| const { selectedProduct: product } = useProduct(); | ||
| const { key } = useRegistration(); | ||
| // FIXME: this needs to be fixed for RMT which allows registering with empty key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
Better wording Co-authored-by: David Díaz <[email protected]>
Use `<Content>` component. Co-authored-by: David Díaz <[email protected]>
Co-authored-by: David Díaz <[email protected]>
|
Just a note about the |
|
I tried to simplify the code in b40dea6, but now it fails with error: See the full log at https://github.com/agama-project/agama/actions/runs/14464157813/job/40562519285#step:8:619. No idea how to fix that... 😟 |
|
OK, now it compiles fine. |
imobachgs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rust part looks good.
rust/agama-lib/src/product/client.rs
Outdated
| .available_addons() | ||
| .await? | ||
| .into_iter() | ||
| .map(|hash| AddonProperties { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to move this code to a separate function. But, for now, it is good enough. Thanks!
Prepare to release Agama 14: * #1994 * #2041 * #2103 * #2178 * #2189 * #2200 * #2205 * #2209 * #2212 * #2213 * #2214 * #2215 * #2216 * #2217 * #2219 * #2220 * #2224 * #2225 * #2226 * #2227 * #2228 * #2230 * #2231 * #2232 * #2233 * #2235 * #2237 * #2239 * #2241 * #2242 * #2244 * #2245 * #2246 * #2247 * #2248 * #2249 * #2250 * #2251 * #2252 * #2253 * #2254 * #2255 * #2256 * #2257 * #2259 * #2260 * #2262 * #2265 * #2266 * #2268 * #2269 * #2271 * #2272 * #2273 * #2275 * #2276 * #2278 * #2281
Problem
Solution
Screenshots
The first proposal:
After registering the registration code field and the button is replaced by "registered" status text: