Skip to content

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Nov 19, 2025

Problem

The software proposal does not include information about whether a pattern was selected by the user or by the installer itself.

{
  "software": {
    "size": "3944742 KiB",
    "patterns": {
      "kde": "None",
      "multimedia": "Auto",
      "apparmor": "None",
      "basic_desktop": "None",
      "gnome": "Auto",
      "xfce": "None",
      "selinux": "Auto",
      "office": "Auto",
      "yast2_basis": "None",
      "yast2_desktop": "None",
      "yast2_server": "None"
    }
}

Additionally, there are other two problems:

  • Capitalization looks wrong.
  • The "size" field is already formatted, whether it should be up to the client.

Solution

  • Distinguish installer (auto) from user-selected (user) patterns and use camelCase.
  • Return the size as a number (in KiB).
{
  "size": 6240723,
  "patterns": {
    "basic_desktop": "none",
    "office": "auto",
    "apparmor": "none",
    "kde": "none",
    "yast2_server": "none",
    "yast2_basis": "auto",
    "yast2_desktop": "none",
    "multimedia": "auto",
    "selinux": "none",
    "xfce": "none",
    "gnome": "user"
  }
}

@imobachgs imobachgs marked this pull request as ready for review November 19, 2025 23:05
@imobachgs imobachgs marked this pull request as draft November 19, 2025 23:05
@imobachgs imobachgs force-pushed the fix-software-proposal branch 4 times, most recently from b57f722 to 6c01cf5 Compare November 24, 2025 20:41
@imobachgs imobachgs force-pushed the fix-software-proposal branch from 6c01cf5 to f1a3bb1 Compare November 24, 2025 20:45
@imobachgs imobachgs force-pushed the fix-software-proposal branch from f1a3bb1 to b4226c0 Compare November 24, 2025 22:29
@imobachgs imobachgs marked this pull request as ready for review November 24, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants