-
Notifications
You must be signed in to change notification settings - Fork 66
Fix an opaque I/O error by installing eulas #2903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: api-v2
Are you sure you want to change the base?
Conversation
Fix it by installing some EULA files
In SLE-16 they are also missing but we only get a log error:
agama-web-server[21355]: Could not read the licenses repository: Os { code: 2, kind: NotFound, message: "No such file or directory" }
21114ac to
993bcea
Compare
|
@imobachgs even better solution than what we discussed @mvidner please fix also agama/rust/agama-lib/src/error.rs Line 76 in 993bcea
|
Before: > Error: I/O error After: > Error: I/O error: No such file or directory (os error 2) OK, we need another fix to make it useful, fs_err in an upcoming commit
Before: > Error: I/O error: No such file or directory (os error 2) After: > Error: I/O error: failed to read directory `/usr/share/agama/eula`: No such file or directory (os error 2)
993bcea to
b360083
Compare
| install6 -D -t "${DESTDIR}${unitdir}" "${SRCDIR}"/share/agama-web-server.service | ||
|
|
||
| # instal licenses | ||
| install6 -D -t "${DESTDIR}${datadir}"/agama/eula/license.final "${SRCDIR}"/share/eula/license.final/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does look a bit suspicious, more like testing data than the real thing, but we can improve upon that while we have a not-crashing agama-web-server.
$ ls /usr/share/agama/eula/license.final/
license.es.txt license.txt license.zh_CN.txt|
@imobachgs says that in the past we had a problem with error messages appearing twice in the error cause chain: #660 , that is a thing to keep an eye out for But in this case I saw the actual messages in |
Problem
In
api-v2, agama-web-server crashes at startup with(tested via /testing_using_container.sh)
Cc @ancorgs @jreidinger
Solution
useit)Testing
Screenshots
No
Documentation
Not crashing is expected