Skip to content

Fix #310 The preference_updated signal is now triggered when using the REST API #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

KrYpTeD974
Copy link

@KrYpTeD974 KrYpTeD974 commented Nov 18, 2024

Changes have been made to the update method of the PreferenceSerializer to trigger the preference_updated signal.

It has been tested for single updates and bulk updates.

I have also added the preference instance to the signal's parameters as it may be needed when you want to retrieve the model bound to a preference, like a workspace, or a user.

@KrYpTeD974
Copy link
Author

KrYpTeD974 commented Nov 21, 2024

@agateblue Sorry to ask, but did you review this PR ? Don't hesitate to ask for any modification!

@agateblue
Copy link
Owner

Hi @KrYpTeD974 , I'm very sorry for the delay. Life has been tough lately, I haven't forgotten you and this will be reviewed, but it might take a couple more weeks. Thank you for your patience.

@KrYpTeD974
Copy link
Author

No worries, take the time you need, life can be tough but time generally help a lot.

Copy link
Owner

@agateblue agateblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience. This is looking good, the tests are very clear, let's merge, and I'll push a release today as well!

@agateblue agateblue merged commit 68a1214 into agateblue:develop Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants