Skip to content

Conversation

@Taneb
Copy link
Member

@Taneb Taneb commented Feb 26, 2025

Supersedes #454 and, to me, justifies removing Categories.Adjoint.Equivalence.Properties entirely, as ⊣equiv-preserves-diagram is a special case of la-preserves-diagram (along with sym).

The proof is mostly the same as in Categories.Adjoint.Equivalence.Properties, apart from !cone.commute, which takes a different route. (I suspect the author of that module seeing that proof before this proof was what led them to believe the equivalence was necessary)

Discussion points:

  • Are these names good enough?
  • Is this the right module to put these laws in?
  • Should we remove Categories.Adjoint.Equivalence.Properties now?
  • What should we do about the comment in Categories.Category.Finite?

JacquesCarette
JacquesCarette previously approved these changes Feb 26, 2025
@JacquesCarette
Copy link
Collaborator

  • do we use 'la' and 'ra' anywhere else? I think I've seen LAdj and RAdj?
  • yes
  • yes
  • they probably need a thorough review. I've never been fully convinced with that definition (but I'm still searching for a good definition of Finite, so it's deeper than just this code, which wasn't mine.)

@Taneb
Copy link
Member Author

Taneb commented Feb 28, 2025

Regarding la and ra as prefixes, I was mostly going off lapc and rapl. We also just use L or R, which I like even less

@JacquesCarette
Copy link
Collaborator

Wasn't it LAPC and RAPL? I agree that a raw L (or R) is too short. I'm just wondering about capitalization at this point!

@Taneb
Copy link
Member Author

Taneb commented Feb 28, 2025

The module is called RAPL, but the definition is rapl

@JacquesCarette JacquesCarette merged commit 5331251 into master Feb 28, 2025
1 check passed
@JacquesCarette JacquesCarette deleted the adjoints-preserve-diagrams branch February 28, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants